DELL plugin - implementation of long lasting operations on Volume by MaciejMis · Pull Request #615 · ODIM-Project/ODIM

MaciejMis · 2021-07-23T15:08:31Z

Hi!
Changes:

Implemented Task service for Dell plugin based on ODIMRA implementation,
Rewritten create and delete actions on Volume:
- For each Volume action plugin creates Task and returns it to user,
- Task is updated by task monitor that monitors state of Volume and its tasks.
Minor code cleanup,
Fix for issue 545

Please add more reviewers if necessary.

…to pluginDell-mmis-merge � Conflicts: � .github/workflows/build_deploy_test.yml � Makefile � plugin-dell/config/config.go � plugin-dell/config/dell_config.json � plugin-dell/dphandler/basicAuth.go � plugin-dell/dphandler/biosSettings.go � plugin-dell/dphandler/biosSettings_test.go � plugin-dell/dphandler/bootorder.go � plugin-dell/dphandler/common.go � plugin-dell/dphandler/createSession.go � plugin-dell/dphandler/getResource.go � plugin-dell/dphandler/managers.go � plugin-dell/dphandler/pluginStatus.go � plugin-dell/dphandler/redfishEvents.go � plugin-dell/dphandler/reset.go � plugin-dell/dphandler/storage.go � plugin-dell/dphandler/storage_test.go � plugin-dell/dphandler/subscribeEvents.go � plugin-dell/dphandler/update.go � plugin-dell/dpmessagebus/publish.go � plugin-dell/dpmiddleware/basicAuthenticate.go � plugin-dell/dpmodel/Device.go � plugin-dell/dpmodel/storage.go � plugin-dell/dputilities/redfishClient.go � plugin-dell/dputilities/utility.go � plugin-dell/go.mod � plugin-dell/go.sum � plugin-dell/main.go

…to pluginDell-mmis-merge � Conflicts: � plugin-dell/go.sum

lgtm-com · 2021-07-23T15:24:31Z

This pull request fixes 1 alert when merging 3ebbb20 into 1c6ab72 - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

lgtm-com · 2021-07-26T06:56:17Z

This pull request fixes 1 alert when merging 205bf22 into e3ca899 - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

bharath-b-hpe · 2021-07-26T16:36:40Z

Hello @MaciejMis

Please check the github action failures.

into mmis-dell-storage

…to mmis-dell-storage

MaciejMis · 2021-08-13T11:59:01Z

Hello @MaciejMis

Please check the github action failures.

Thanks for reply. I fixed tests, all checks should pass now.

lgtm-com · 2021-08-13T12:10:46Z

This pull request fixes 1 alert when merging f038f81 into 117be79 - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

lgtm-com · 2021-08-13T13:39:37Z

This pull request fixes 1 alert when merging 93c9b7e into 117be79 - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

…to mmis-dell-storage

lgtm-com · 2021-08-17T11:09:51Z

This pull request fixes 1 alert when merging b94f940 into 2f48f5d - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

…to mmis-dell-storage

lgtm-com · 2021-08-18T10:35:54Z

This pull request fixes 1 alert when merging 3d1e715 into 2e8ec2e - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

lgtm-com · 2021-08-18T11:41:13Z

This pull request fixes 1 alert when merging 876f9a6 into 2e8ec2e - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

…to mmis-dell-storage � Conflicts: � Makefile

lgtm-com · 2021-08-31T11:02:14Z

This pull request fixes 1 alert when merging 7252c61 into fa26fe3 - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

bharath-b-hpe

Please include license header in all new files added and also execute golint, go fmt tools in the source directories containing changes.

bharath-b-hpe · 2021-09-03T04:14:28Z

Please update DBConf in https://github.com/ODIM-Project/ODIM/blob/mmis-dell-storage/odim-controller/helmcharts/dellplugin/dellplugin/templates/configmaps.yaml too for kubernetes deployment

Reference
https://github.com/ODIM-Project/ODIM/blob/mmis-dell-storage/odim-controller/helmcharts/odimra-config/templates/configmaps.yaml#L28

plugin-dell/dputilities/taskService.go

plugin-dell/dphandler/storage.go

lgtm-com · 2021-09-08T10:15:58Z

This pull request fixes 1 alert when merging a65e51f into 1082af7 - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

into mmis-dell-storage

lgtm-com · 2021-09-08T11:31:41Z

This pull request fixes 1 alert when merging adf0636 into 1082af7 - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

lgtm-com · 2021-09-08T12:41:46Z

This pull request fixes 1 alert when merging f569263 into 817c69c - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

…to mmis-dell-storage

lgtm-com · 2021-09-23T14:51:05Z

This pull request fixes 1 alert when merging 3721ca7 into 608e31e - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

ashraf-vazeer · 2021-09-24T06:40:03Z

@MaciejMis did we get approval from TSC for this feature to be added to ODIM?

MaciejMis · 2021-09-24T10:40:27Z

@MaciejMis did we get approval from TSC for this feature to be added to ODIM?

Hi! Yes, quite some time ago :)

lgtm-com · 2021-09-28T13:08:21Z

This pull request fixes 1 alert when merging 926b445 into d7648ad - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

ashraf-vazeer · 2021-09-29T05:54:57Z

@MaciejMis did we get approval from TSC for this feature to be added to ODIM?

Hi! Yes, quite some time ago :)

@MaciejMis ,

didn't find any reference in the proposal table regarding updating Dell plugin to handle tasks.
Following is the proposal table.
https://wiki.odim.io/pages/viewpage.action?pageId=327873

Can this be discussed in TSC call and concluded, before we can to go ahead with approving this PR?

Thanks
Ashraf

jeevan-kamkar and others added 7 commits January 15, 2021 13:53

odim 317:Adding the dell plugin base code

1bbcefd

odim 317:Updating the github actions

cdc7c9f

Improved docker configuration for Dell plugin

51adeed

Updated numerous functions for dell plugin

7b1c953

Merge branch 'development' of https://github.com/ODIM-Project/ODIM in…

e4d3404

…to pluginDell-mmis-merge � Conflicts: � plugin-dell/go.sum

Cleanup

3ebbb20

MaciejMis requested review from Bharath-KKB, amar-shalgar and bharath-b-hpe July 23, 2021 15:08

MaciejMis added prio:normal normal priority, can be taken up after high priority issues are addressed status:new This tag is attached to a new issue during creation only type:feature issue type is created for adding a new feature(enhancement) to the system labels Jul 23, 2021

Merge branch 'development' into mmis-dell-storage

205bf22

Mis, Maciej added 3 commits August 13, 2021 13:51

Fixed Volume tests

42f5615

Merge branch 'mmis-dell-storage' of https://github.com/ODIM-Project/ODIM

74565f9

into mmis-dell-storage

Merge branch 'development' of https://github.com/ODIM-Project/ODIM in…

f038f81

…to mmis-dell-storage

Fixed svc-systems tests related to DeleteVolume.

93c9b7e

Mis, Maciej added 2 commits August 17, 2021 12:55

Fixed configs

74ed5fc

Merge branch 'development' of https://github.com/ODIM-Project/ODIM in…

b94f940

…to mmis-dell-storage

Mis, Maciej added 2 commits August 18, 2021 12:19

Updated dell config script

e881acb

Merge branch 'development' of https://github.com/ODIM-Project/ODIM in…

3d1e715

…to mmis-dell-storage

Changed order of cipher suites

876f9a6

Merge branch 'development' of https://github.com/ODIM-Project/ODIM in…

7252c61

…to mmis-dell-storage � Conflicts: � Makefile

bharath-b-hpe reviewed Sep 2, 2021

View reviewed changes

bharath-b-hpe reviewed Sep 3, 2021

View reviewed changes

plugin-dell/dputilities/taskService.go Show resolved Hide resolved

bharath-b-hpe reviewed Sep 6, 2021

View reviewed changes

plugin-dell/dphandler/storage.go Outdated Show resolved Hide resolved

Mis, Maciej and others added 3 commits September 6, 2021 13:34

License headers added.

3e438dc

Kubernetes deployment for dell plugin updated

0e9bc55

Merge branch 'development' into mmis-dell-storage

a65e51f

Mis, Maciej added 3 commits September 8, 2021 13:07

Added OnDisk sentinel port and master set parameters

7ae1d01

Removed unnecessary VolumeType parameter validation

804cd33

Merge branch 'mmis-dell-storage' of https://github.com/ODIM-Project/ODIM

adf0636

into mmis-dell-storage

Merge branch 'development' into mmis-dell-storage

f569263

Mis, Maciej added 2 commits September 23, 2021 16:14

StatusCode included in taskmon

6a3359f

Merge branch 'development' of https://github.com/ODIM-Project/ODIM in…

3721ca7

…to mmis-dell-storage

bharath-b-hpe approved these changes Sep 24, 2021

View reviewed changes

Merge branch 'development' into mmis-dell-storage

926b445

bharath-b-hpe requested review from jeevan-kamkar and shivacharanms September 30, 2021 14:17

Comments

Conversation

MaciejMis commented Jul 23, 2021

Uh oh!

lgtm-com bot commented Jul 23, 2021

Uh oh!

lgtm-com bot commented Jul 26, 2021

Uh oh!

bharath-b-hpe commented Jul 26, 2021

Uh oh!

MaciejMis commented Aug 13, 2021

Uh oh!

lgtm-com bot commented Aug 13, 2021

Uh oh!

lgtm-com bot commented Aug 13, 2021

Uh oh!

lgtm-com bot commented Aug 17, 2021

Uh oh!

lgtm-com bot commented Aug 18, 2021

Uh oh!

lgtm-com bot commented Aug 18, 2021

Uh oh!

lgtm-com bot commented Aug 31, 2021

Uh oh!

bharath-b-hpe left a comment

Choose a reason for hiding this comment

Uh oh!

bharath-b-hpe commented Sep 3, 2021

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented Sep 8, 2021

Uh oh!

lgtm-com bot commented Sep 8, 2021

Uh oh!

lgtm-com bot commented Sep 8, 2021

Uh oh!

lgtm-com bot commented Sep 23, 2021

Uh oh!

ashraf-vazeer commented Sep 24, 2021

Uh oh!

MaciejMis commented Sep 24, 2021

Uh oh!

lgtm-com bot commented Sep 28, 2021

Uh oh!

ashraf-vazeer commented Sep 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants